feat(free-units): Add free_units_per_events and free_units_per_total_aggregation #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
force-pushed
the
free-units-migration
branch
2 times, most recently
from
10c2d69 to
df2ca4a
Compare
rsempe
force-pushed
the
free-units-migration
branch
from
df2ca4a to
775126a
Compare
rsempe
force-pushed
the
free-units-migration
branch
from
775126a to
1ac5370
Compare
rsempe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to add the ability to:
distinct transactionnumber of distinct transactionsor onthe monetary total amountDescription
This is the second step of adding fixed amount and free units to the percentage charge.
The goal of this PR is to:
fixed_amount_targetfromCharge#propertiesfree_units_per_eventstoCharge#propertiesfree_units_per_total_aggregationtoCharge#propertiesRelated Task
getlago/lago#92
How Has This Been Tested?
A full QA will be performed when the feature will be 100% implemented.